[commit] update_watchpoint is used with s/w watchpoints too

[Joel Brobecker <brobecker at adacore dot com>]

Hello,

While reviewing some patches in this area, I noticed that there was
a disconnect between the documentation of update_watchpoint and its
actual usage. I also felt it was imcomplete as well, as it was
mentioning the parsing of the watchpoint expression, but not the
condition. So I fix all of that.

There is still one part that I also find slightly confusing:

    If the watchpoint is disabled, do nothing

In fact, what this comments means is that, "if the disposition of the
watchpoint is to be deleted at the next stop"...  I initially understood
it as, if the watchpoint state was bp_disabled. Would it be OK if I
changed the above to:

    If the watchpoint disposition is disp_del_at_next_stop, then do nothing.

?

2008-12-22  Joel  Brobecker  <brobecker@adacore.com>

        * breakpoint.c (update_watchpoint): Adjust and extend the description
        of this function.  Fix one error message accordingly.

Tested on x86-linux. Checked in.

-- 
Joel

Attachment: breakpoint.c.diff
Description: Text document