This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: some news about the x86_64-windows port...


Hi Chris,

First, thanks very much for the ultra-fast review. It will make
the merging that much easier. Thanks a lot.

> Other than that minor nit, the windowss-specific stuff looks good to me.
> I assume that you tested that it all still worked on 32-bit windows
> right?

Yes I did. The caveat is that I tested it with AdaCore's testsuite
as I can't seem to be able to make the testsuite run smoothly on
Windows. Not sure what's going on, since I think I have the latest
of dejagnu and expect. The testsuite just keeps timing out and
never completes (that was on XP, and I have two left hands when
it comes to Windows).  On the other hand, I let it go, because
the nature of the changes I made were such that I felt safe with
just running our testsuite. Our testsuite is not as extensive as
the official one, but it does cover all the major areas I believe.

I hope this is still good enough.

> Btw, I'm sorry about all of the places where I used DWORD
> inappropriately in win32-nat.c.  I should have known better than that
> and it looks like I made your job harder.

No worries at all. What really made my job harder was actually the fact
that Microsoft decided that sizeof (long) should be 4 and not 8.
I think the reason they gave was that most legacy application that
used a long "probably" didn't need a larger long.  So they argue
that this decision should avoid some unnecessary memory waste.
I can probably find the article again, if anyone is interested.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]