This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/win32] move win32_xfer_shared_library to (new) win32-tdep...


On Sat, Jan 10, 2009 at 01:08:43PM +0400, Joel Brobecker wrote:
>Hello,
>
>This patch moves the win32_xfer_shared_library function to a file
>that is not specific to the target CPU.  I introduced win32-tdep,
>to follow the naming scheme used by win32-nat, even though these
>file can also work on 64bit windows.

If this file can work on 64 bit windows then it seems like it should be
renamed to something more generic rather than potentially duplicating
the same code in two places.

Should win32-nat.c just be renamed to windows-nat.c?

(I assume that RMS will be happy to see the "win" part go away anyway)

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]