This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFA] gdbserver: also issue remote debug information for getpkt in no-ack-mode


Thanks, Pedro,
I committed the patch without that spurious empty line.


Pierre Muller
Pascal language support maintainer for GDB




> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé?: Saturday, February 14, 2009 12:49 AM
> À?: gdb-patches@sourceware.org
> Cc?: Pierre Muller
> Objet?: Re: [RFA] gdbserver: also issue remote debug information for
> getpkt in no-ack-mode
> 
> On Monday 09 February 2009 16:04:08, Pierre Muller wrote:
> 
> >   Is this OK?
> 
> Looks good to me (tiny comment in the patch below).  I thought I
> had already fixed this in HEAD, but I see the fix done in
> the multi-process branch only.  :-)
> 
> >   Could someone tell me how to setup a
> > dejagnu target to run the testsuite
> > with cygwin gdbserver on a cygwin machine?
> 
> See here:
> 
>  http://sourceware.org/gdb/wiki/Native_gdbserver_testing
> 
> This works on Cygwin, as I use this method there.
> 
> > +  else
> > +    {
> > +      if (remote_debug)
> > +	{
> > +	  fprintf (stderr, "getpkt (\"%s\");  [no ack sent] \n", buf);
> > +	  fflush (stderr);
> > +	}
> > +
> 
> Spurious blank line here.
> 
> > +    }
> >
> 
> --
> Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]