This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Modernize solaris threads support.

From: Pedro Alves <pedro at codesourcery dot com>
To: Eli Zaretskii <eliz at gnu dot org>
Cc: gdb-patches at sourceware dot org
Date: Mon, 16 Feb 2009 19:34:52 +0000
Subject: Re: Modernize solaris threads support.
References: <200902160549.49108.pedro@codesourcery.com> <uhc2uw64a.fsf@gnu.org>

On Monday 16 February 2009 19:09:57, Eli Zaretskii wrote:
> Why did you need to remove these prototypes while at that?

Do you need the prototypes at all?  These are static
functions that are defined before any use.  Adjusting unneeded
prototypes is just unnecessary, redundant extra work, exactly in
cases like this one.

> Also, the argument you added is unused inside these functions.
> Shouldn't we do something to shut up GCC warnings about them?

No need.  Nowhere in GDB's codebase do we do that currently.  We
build gdb with -Wno-unused instead.

> Other than that, the changes to go32-nat.c are approved.

Thanks.

-- 
Pedro Alves

Follow-Ups:
- Re: Modernize solaris threads support.
  - From: Eli Zaretskii

References:
- Modernize solaris threads support.
  - From: Pedro Alves
- Re: Modernize solaris threads support.
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]