This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Modernize solaris threads support.
On Tuesday 24 February 2009 14:52:05, Pierre Muller wrote:
> I fixed compilation with that little change:
>
> $ cvs diff -up windows-nat.c
> Index: windows-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/windows-nat.c,v
> retrieving revision 1.181
> diff -u -p -r1.181 windows-nat.c
> --- windows-nat.c 23 Feb 2009 00:03:50 -0000 1.181
> +++ windows-nat.c 24 Feb 2009 14:50:30 -0000
> @@ -113,7 +113,7 @@ static int debug_registers_used;
> #define DEBUG_EXCEPT(x) if (debug_exceptions) printf_unfiltered x
>
> static void windows_stop (ptid_t);
> -static int windows_thread_alive (ptid_t);
> +static int windows_thread_alive (struct target_ops *, ptid_t);
> static void windows_kill_inferior (void);
>
> static enum target_signal last_sig = TARGET_SIGNAL_0;
> @@ -1432,7 +1432,7 @@ get_windows_debug_event (struct target_o
> if (!retval || saw_create != 1)
> {
> if (continue_status == -1)
> - windows_resume (minus_one_ptid, 0, 1);
> + windows_resume (ops, minus_one_ptid, 0, 1);
> else
> CHECK (windows_continue (continue_status, -1));
> }
>
> Should I commit it?
Yes, please (with a ChangeLog entry, of course). That's a
pretty obvious fix. Thank you!
>
>
> Pierre Muller
> Pascal language support maintainer for GDB
>
>
>
>
> > -----Message d'origine-----
> > De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] De la part de Pedro Alves
> > Envoyé?: Tuesday, February 24, 2009 3:39 PM
> > À?: Pierre Muller
> > Cc?: gdb-patches@sourceware.org
> > Objet?: Re: Modernize solaris threads support.
> >
> > On Tuesday 24 February 2009 14:33:05, Pierre Muller wrote:
> > > Pedro,
> > > you also broke windows-nat.c compilation...
> >
> > Uh! Darn it.
> >
> > Ok, give me a moment to go through all to_resume implementations, as
> > it seems I missed a few.
> >
> > Sorry about that.
> >
> > In any case, as I said before, I had to touch most *native*
> > configurations, so it's likelly that I missed several cases. If
> > you do spot one, the fix is *dead trivial*, so go ahead and commit a
> > fix as obvious ...
> >
> > --
> > Pedro Alves
>
>
--
Pedro Alves