This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix a crash when displaying variables from shared library.

From: Joel Brobecker <brobecker at adacore dot com>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: tromey at redhat dot com, Pedro Alves <pedro at codesourcery dot com>, gdb-patches at sourceware dot org
Date: Mon, 9 Mar 2009 11:33:16 -0700
Subject: Re: [patch] Fix a crash when displaying variables from shared library.
References: <20090223010759.GA30997@adacore.com> <8ac60eac0902231012lb42bcb1q8b8cf19ad2ac192@mail.gmail.com> <8ac60eac0903021830w363783ear7d4c8fc1177d6448@mail.gmail.com> <m37i36jeop.fsf@fleche.redhat.com> <8ac60eac0903041124s1aafb562u225f268c4d1511dd@mail.gmail.com> <20090305200415.GC3744@adacore.com> <8ac60eac0903051546r1eaffc89tf1f35b21e6dc1b40@mail.gmail.com> <8ac60eac0903051906r5d41990bwcaccdfb4accef562@mail.gmail.com> <20090306174822.GJ3744@adacore.com> <8ac60eac0903061406t610ba1a1y1c62e5ee30332c7c@mail.gmail.com>

> 2009-03-06  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
> 	    * solib.c (solib_contains_address_p): New function.
> 	    (solib_name_from_address): Use it.
> 	    * printcmd.c (display_uses_solib_p): Use it.
> 	    * solib.h (solib_contains_address_p): Declare it.

Looks great to me. Go ahead and check it in.

Thanks,
-- 
Joel

Follow-Ups:
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Paul Pluzhnikov

References:
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Paul Pluzhnikov
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Tom Tromey
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Paul Pluzhnikov
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Joel Brobecker
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Paul Pluzhnikov
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Paul Pluzhnikov
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Joel Brobecker
- Re: [patch] Fix a crash when displaying variables from shared library.
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]