This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR exp/9103


(slightly edited to correct top-posting)

El miÃ, 11-03-2009 a las 14:13 -0300, Andre Oliveira Loureiro do Baixo
escribiÃ:
> On Wed, Mar 11, 2009 at 2:08 PM, Tom Tromey <tromey@redhat.com> wrote:
> >>>>>> "Andre" == Andre Oliveira Loureiro do Baixo <andreolb@gmail.com> writes:
> >
> > Andre> The patch works correctly because the function inside the modified
> > Andre> condition (val_print_string) scans the string using the size of each
> > Andre> character of the string. This size is passed to the function using the
> > Andre> parameter TYPE_LENGTH (elttype). Char * strings are printed by this
> > Andre> function, the only difference is that wchar_t* strings didn't get
> > Andre> inside the condition, and now they do.
> >
> > Yeah, but it isn't as useful as it could be, because it doesn't
> > properly handle charset conversions.  Also, I suspect it won't work in
> > C, where wchar_t is a typedef.
> >
> > Try this patch instead:
> >
> >    http://sourceware.org/ml/gdb-patches/2009-01/msg00533.html
>
> Yes, it works in C with no problems at all.

Tromey, do you think your charset branch will make it in time for 7.0?
If not, we could consider Andre's approach...
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]