This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] How to get target_ops from to_kill method?
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org, Tristan Gingold <gingold at adacore dot com>
- Date: Mon, 16 Mar 2009 13:16:13 -0400
- Subject: Re: [RFC] How to get target_ops from to_kill method?
- References: <20090316162247.GE9576@adacore.com> <200903161642.27406.pedro@codesourcery.com>
> Thank you very much for handling these breakages.
No problem, I know how easily they can happen.
[about having a target_ops argument for all methods]
> Mostly, because it's a bunch of work that affects most native
> targets. I tried hard to avoid missing any conversion in
> the last set of changes, but, it ended up I broke a lot
> of stuff... But, yeah, there's a lot of inconsistency
> here.
Yeah, fixing them all would be a lot of work, indeed. How about
we decide that, from now on, all new methods should have a target_ops
parameter as their first argument? Do you think that it would be
a good thing? We can fix the others as needed...
> I much prefer this version over the other. It's incremental, and
> doesn't add any hack or reference to the current_target global.
Me too. I haven't checked it in, yet, because it would become
unecessary if we added the target_ops parameter to the to_kill
method, which I can take care of.... What do you think?
--
Joel