This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFA] AR Index, remove yacc-lex sources for boolean tests


I tried several times to commit that
approved patch, but I always get the same
error: Could not open lock file `/cvs/gdbadmin/ss/,gdb_ari.sh,'

I suppose that members allowed to commit to /cvs/src 
are not necessarily the same as for /cvs/gdbadmin...

Joel found out that this directory is writable only
by group  gdbadmin, and offered to commit it for me.

Thanks Joel,
the patch is below.


Pierre Muller
Pascal language support maintainer for GDB



PS: the commit.txt file was just for
the cvs commit -F commit.txt gdb_ari.sh
as this directory has no ChangeLog.



$ cat commit.txt
        * gdb_ari.sh (boolean, true, false): Do not consider lex and yacc
sources.

Pierre@d620-muller ~/ss
$ cvs diff -up gdb_ari.sh
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.77
diff -u -p -r1.77 gdb_ari.sh
--- gdb_ari.sh  24 Oct 2007 20:24:55 -0000      1.77
+++ gdb_ari.sh  17 Mar 2009 22:39:46 -0000
@@ -1364,7 +1364,9 @@ Do not use `boolean'\'',  use `int'\'' i
     category["boolean"] = ari_regression
 }
 /(^|[^_[:alnum:]])boolean([^_[:alnum:]]|$)/ {
-    fail("boolean")
+    if (is_yacc_or_lex == 0) {
+       fail("boolean")
+    }
 }

 BEGIN { doc["false"] = "\
@@ -1372,7 +1374,9 @@ Definitely do not use `false'\'' in bool
     category["false"] = ari_regression
 }
 /(^|[^_[:alnum:]])false([^_[:alnum:]]|$)/ {
-    fail("false")
+    if (is_yacc_or_lex == 0) {
+       fail("false")
+    }
 }

 BEGIN { doc["true"] = "\
@@ -1380,7 +1384,9 @@ Do not try to use `true'\'' in boolean e
     category["true"] = ari_regression
 }
 /(^|[^_[:alnum:]])true([^_[:alnum:]]|$)/ {
-    fail("true")
+    if (is_yacc_or_lex == 0) {
+       fail("true")
+    }
 }

 BEGIN { doc["if assignment"] = "\

> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de 'Daniel Jacobowitz'
> Envoyé?: Thursday, March 12, 2009 5:32 PM
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFA] AR Index, remove yacc-lex sources for boolean tests
> 
> On Thu, Mar 12, 2009 at 11:29:26AM +0100, Pierre Muller wrote:
> >   This simple patch
> > avoids  testing lex and yacc files
> > for 'boolean' 'false' and 'true'.
> >
> >   Daniel, can I check this in?
> 
> Yes, go ahead.
> 
> --
> Daniel Jacobowitz
> CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]