This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] (dump_raw_expression): Print note if non-NULL.


On Tue, Mar 17, 2009 at 6:23 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> Ok to check in?
> Doug> 2009-03-17  Doug Evans  <dje@google.com>
> Doug>   * expprint.c (dump_raw_expression): Print note if non-NULL.
>
> Looks good to me, please go ahead.
>
> Doug> -  fprintf_filtered (stream, "'\n\tLanguage %s, %d elements, %ld bytes each.\n",
> Doug> +  if (note)
> Doug> +    fprintf_filtered (stream, ", %s:", note);
> Doug> +  fprintf_filtered (stream, "\n\tLanguage %s, %d elements, %ld bytes each.\n",
>
> I notice that this removes a single quote (see the old fprintf_filtered).
> But, I can't see why we would want that anyway.

The single quote is a left over from an earlier version.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]