This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] PR exp/9103
> Cc: mark.kettenis@xs4all.nl, brobecker@adacore.com, bauerman@br.ibm.com,
> andreolb@gmail.com, gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Tue, 17 Mar 2009 20:50:50 -0600
>
> Thanks, after this I noticed that the manual has a section on install
> requirements. What do you think of the appended patch?
It's okay, but I have two comments:
> +@item iconv
> +@value{GDBN}'s features related to character sets require a
> +functioning @code{iconv} implementation.
I think it would be good here to add a cross-reference to where these
features are described, to make more clear what is at stake.
> +@value{GDBN}'s top-level @file{configure} and @file{Makefile} will
> +arrange to build Libiconv if a directory named @file{libiconv} appears
> +in the @file{src} directory.
`src'? Ah, you are talking about the `src' tree that includes GDB,
Binutils, libiberty, bfd, etc., right? I'm not sure this will be
clear to anyone who does not habitually build these packages out of
the same tree. How about adding that you are talking about the the
`libiconv' directory being a sibling directory to `gdb' under the same
parent directory? (Does it have to be called `src', btw?)