Re: [PATCH] gdb_ari.sh cleanup

[Joel Brobecker <brobecker at adacore dot com>]

> I did not handle two macros, because
> they are unused but are still present in docs:
> REGISTER_U_ADDR
> PROCESS_LINENUMBER_HOOK

Let's just remove them from the documentation. It's a very simple
change, but let me know if you'd like me to take care of it.

> Miscellaneous questions:
> 1a) Should the PARAMS rule be moved to code section?
> 1b) Same question for __FUNCTION__ rule.
> 1c) Idem for ARGSUSED

Does it really make a difference? If it helps you analyze the results,
then I'd say go for it.

> 1d) Idem for

(name missing?)

> 2) LITTLE_ENDIAN and BIG_ENDIAN still exists in configure,
> should I still remove the rule?

I don't think so. I don't know what the details are, but I'm wondering
whether the macros might be defined by the compiler, thus making it
possible for us to accidently reintroduce this usage again.  I'd say,
let's keep the rule.

> 3) HAVE_VFORK is still present in config.in
> should I keep the rule or should we remove it from config.in first?

We need to keep the rule. That macro is still used by gdb_vfork.h
and it is a valid use of that macro. In a way, this is very similar
to the use of "abort" - only very selected uses are allowed.

-- 
Joel