This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFA] ARI fix: remove 6 last %p occurences


Thanks for the approval.

I checked the patch in,
but left the two lines together, even if they
do wrap as they are too long in symmisc.c


Pierre Muller
Pascal language support maintainer for GDB




> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé?: Tuesday, April 21, 2009 2:06 AM
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFA] ARI fix: remove 6 last %p occurences
> 
> >>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:
> 
> Pierre>   The two last changes in symmisc.c were postponed
> Pierre> in my first patch because I had a question:
> [...]
> >> I don't know the rules for C,
> >> is an addition of a pointer and a integer always of type pointer?
> Pierre> But nobody answered :(
> 
> Sorry about that.  Yes, in C, the addition of a pointer and an integer
> always has pointer type.
> 
> Pierre> Is this OK?
> 
> Yes, thanks.
> 
> Pierre> +				   host_address_to_string (
> Pierre> +				    psymtab->objfile-
> >global_psymbols.list
> 
> The formatting here looks a bit weird.  There aren't many good
> choices, but usually I just choose to let the line wrap rather than
> splitting after the "(".
> 
> Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]