This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Patch: FYI: use AC_HELP_STRING
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 21 Apr 2009 10:59:42 -0600
- Subject: Patch: FYI: use AC_HELP_STRING
- Reply-to: tromey at redhat dot com
This is the patch I promised yesterday.
It fixes the --help output to use upper case where appropriate.
I also took the opportunity to make gdb's configure consistently use
AC_HELP_STRING.
Tom
2009-04-21 Tom Tromey <tromey@redhat.com>
* configure: Rebuild.
* acinclude.m4 (AM_ICONV): Use AC_HELP_STRING.
* configure.ac: Use AC_HELP_STRING. Use upper case for variables
in help.
Index: acinclude.m4
===================================================================
RCS file: /cvs/src/src/gdb/acinclude.m4,v
retrieving revision 1.27
diff -u -r1.27 acinclude.m4
--- acinclude.m4 26 Mar 2009 01:18:35 -0000 1.27
+++ acinclude.m4 21 Apr 2009 16:56:08 -0000
@@ -175,7 +175,7 @@
dnl those with the standalone portable GNU libiconv installed).
AC_ARG_WITH([libiconv-prefix],
-[ --with-libiconv-prefix=DIR search for libiconv in DIR/include and DIR/lib], [
+ AC_HELP_STRING([--with-libiconv-prefix=DIR], [search for libiconv in DIR/include and DIR/lib]), [
for dir in `echo "$withval" | tr : ' '`; do
if test -d $dir/include; then LIBICONV_INCLUDE="-I$dir/include"; fi
if test -d $dir/lib; then LIBICONV_LIBDIR="-L$dir/lib"; fi
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.94
diff -u -r1.94 configure.ac
--- configure.ac 21 Apr 2009 10:13:05 -0000 1.94
+++ configure.ac 21 Apr 2009 16:56:10 -0000
@@ -95,7 +95,7 @@
debugdir=${libdir}/debug
AC_ARG_WITH(separate-debug-dir,
-[ --with-separate-debug-dir=path Look for global separate debug info in this path [LIBDIR/debug]],
+AC_HELP_STRING([--with-separate-debug-dir=PATH], [Look for global separate debug info in this path [LIBDIR/debug]]),
[debugdir="${withval}"])
AC_DEFINE_DIR(DEBUGDIR, debugdir,
@@ -129,7 +129,7 @@
# Check whether to support alternative target configurations
AC_ARG_ENABLE(targets,
-[ --enable-targets alternative target configurations],
+AC_HELP_STRING([--enable-targets=TARGETS], [alternative target configurations]),
[case "${enableval}" in
yes | "") AC_ERROR(enable-targets option must specify target names or 'all')
;;
@@ -139,7 +139,7 @@
# Check whether to enable 64-bit support on 32-bit hosts
AC_ARG_ENABLE(64-bit-bfd,
-[ --enable-64-bit-bfd 64-bit support (on hosts with narrower word sizes)],
+AC_HELP_STRING([--enable-64-bit-bfd], [64-bit support (on hosts with narrower word sizes)]),
[case "${enableval}" in
yes) want64=true ;;
no) want64=false ;;
@@ -247,7 +247,7 @@
# Enable CLI.
AC_ARG_ENABLE(gdbcli,
-[ --disable-gdbcli disable command-line interface (CLI)],
+AC_HELP_STRING([--disable-gdbcli], [disable command-line interface (CLI)]),
[case $enableval in
yes)
;;
@@ -268,7 +268,7 @@
# Enable MI.
AC_ARG_ENABLE(gdbmi,
-[ --disable-gdbmi disable machine-interface (MI)],
+AC_HELP_STRING([--disable-gdbmi], [disable machine-interface (MI)]),
[case $enableval in
yes | no)
;;
@@ -287,7 +287,7 @@
# Enable TUI.
AC_ARG_ENABLE(tui,
-[ --enable-tui enable full-screen terminal user interface (TUI)],
+AC_HELP_STRING([--enable-tui], [enable full-screen terminal user interface (TUI)]),
[case $enableval in
yes | no | auto)
;;
@@ -297,7 +297,7 @@
# Enable gdbtk.
AC_ARG_ENABLE(gdbtk,
-[ --enable-gdbtk enable gdbtk graphical user interface (GUI)],
+AC_HELP_STRING([--enable-gdbtk], [enable gdbtk graphical user interface (GUI)]),
[case $enableval in
yes | no)
;;
@@ -318,7 +318,7 @@
# Libunwind support.
AC_ARG_WITH(libunwind,
-[ --with-libunwind Use libunwind frame unwinding support],
+AC_HELP_STRING([--with-libunwind], [Use libunwind frame unwinding support]),
[case "${withval}" in
yes) enable_libunwind=yes ;;
no) enable_libunwind=no ;;
@@ -348,7 +348,7 @@
# Profiling support.
AC_ARG_ENABLE(profiling,
-[ --enable-profiling enable profiling of GDB],
+AC_HELP_STRING([--enable-profiling], [enable profiling of GDB]),
[case $enableval in
yes | no)
;;
@@ -927,9 +927,7 @@
fi
AC_ARG_WITH(included-regex,
- [ --without-included-regex don't use included regex; this is the default
- on systems with version 2 of the GNU C library
- (use with caution on other system)],
+ AC_HELP_STRING([--without-included-regex], [don't use included regex; this is the default on systems with version 2 of the GNU C library (use with caution on other system)]),
gdb_with_regex=$withval,
gdb_with_regex=$gdb_use_included_regex)
if test "$gdb_with_regex" = yes; then
@@ -1482,7 +1480,7 @@
dnl Handle optional features that can be enabled.
AC_ARG_WITH(sysroot,
-[ --with-sysroot[=DIR] Search for usr/lib et al within DIR.],
+AC_HELP_STRING([--with-sysroot[=DIR]], [Search for usr/lib et al within DIR.]),
[
case ${with_sysroot} in
yes) TARGET_SYSTEM_ROOT='${exec_prefix}/${target_alias}/sys-root' ;;
@@ -1519,7 +1517,7 @@
system_gdbinit=
AC_ARG_WITH(system-gdbinit,
-[ --with-system-gdbinit=file Automatically load a system-wide gdbinit file],
+AC_HELP_STRING([--with-system-gdbinit=FILE], [Automatically load a system-wide gdbinit file]),
[system_gdbinit=${withval}])
AC_DEFINE_DIR(SYSTEM_GDBINIT, system_gdbinit,
@@ -1546,7 +1544,7 @@
esac
AC_ARG_ENABLE(werror,
- [ --enable-werror treat compile warnings as errors],
+ AC_HELP_STRING([--enable-werror], [treat compile warnings as errors]),
[case "${enableval}" in
yes | y) ERROR_ON_WARNING="yes" ;;
no | n) ERROR_ON_WARNING="no" ;;
@@ -1579,7 +1577,7 @@
esac
AC_ARG_ENABLE(build-warnings,
-[ --enable-build-warnings Enable build-time compiler warnings if gcc is used],
+AC_HELP_STRING([--enable-build-warnings], [Enable build-time compiler warnings if gcc is used]),
[case "${enableval}" in
yes) ;;
no) build_warnings="-w";;
@@ -1593,7 +1591,7 @@
echo "Setting compiler warning flags = $build_warnings" 6>&1
fi])dnl
AC_ARG_ENABLE(gdb-build-warnings,
-[ --enable-gdb-build-warnings Enable GDB specific build-time compiler warnings if gcc is used],
+AC_HELP_STRING([--enable-gdb-build-warnings], [Enable GDB specific build-time compiler warnings if gcc is used]),
[case "${enableval}" in
yes) ;;
no) build_warnings="-w";;
@@ -1831,7 +1829,7 @@
# not part of the source tree.
#
AC_ARG_ENABLE(sim,
-[ --enable-sim Link gdb with simulator],
+AC_HELP_STRING([--enable-sim], [Link gdb with simulator]),
[echo "enable_sim = $enable_sim";
echo "enableval = ${enableval}";
case "${enableval}" in
@@ -1911,7 +1909,7 @@
# Enable multi-ice-gdb-server.
AC_ARG_ENABLE(multi-ice,
-[ --enable-multi-ice build the multi-ice-gdb-server],
+AC_HELP_STRING([--enable-multi-ice], [build the multi-ice-gdb-server]),
[case $enableval in
yes | no)
;;