This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] gdbadmin/ss/gdb_find.sh cleanup


    I looked at gdb_find.sh script and discovered
that some of the excluded files do not exist anymore.

  The patch below creates no changes on the ARI output
for me.

The new version of gdb_find.sh is then only:
>>>>>>>>>>>>>>>> `cat gdb_find.sh`
#!/bin/sh

# A find that prunes files that GDB users shouldn't be interested in.

find "$@" \
    -name signals -prune -o \
    -name testsuite -prune -o \
    -name gdbserver -prune -o \
    -name gnulib -prune -o \
    -name rdi-share -prune -o \
    -name osf-share -prune -o \
    -name nlm -prune -o \
    -name '*-stub.c' -prune -o \
    -name '*-exp.c' -prune -o \
    -name 'sh64*' -prune -o \
    -name remote-mips.c -prune -o \
    -type f -name '*.[lyhc]' -print

>>>>>>>>>>>>>>>> end of `cat gdb_find.sh`

Is this patch OK?



  I perfectly understand why *-stub.c patterns are excluded,
*-exp.c patterns should not even appear in a distribution of gdb sources,
but this only also doesn't hurt, I am more curious about
'sh64*' and 'remote-mips.c'
 sh64* covers 
gdb/sh64-tdep.c file
and 
config/sh64 directory.

  Why are those patterns excluded?
Who are the maintainers of these files?
Should we also remove those two lines?

 (I tried removing these two patterns also and I do get 
some more warnings in that case).


Pierre Muller
Pascal language support maintainer for GDB


Commit entry:
	* remove obsolete patterns

$ cvs diff gdb_find.sh
Index: gdb_find.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_find.sh,v
retrieving revision 1.12
diff -r1.12 gdb_find.sh
15,17d14
<     -name ada-lex.c -prune -o \
<     -name cp-name-parser.c -prune -o \
<     -name stop-gdb.c -prune -o \
19,21d15
<     -name lynx-nat.c -prune -o \
<     -name ppc-bdm.c -prune -o \
<     -name ppc-bdm.c -prune -o \
23,24d16
<     -name remote-sds.c -prune -o \
<     -name remote-sds.c -prune -o \

Pierre@d620-muller ~/ss


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]