This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] C++ : breakpoint in templates
- From: Tom Tromey <tromey at redhat dot com>
- To: Jerome Guitton <guitton at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 23 Apr 2009 15:48:51 -0600
- Subject: Re: [RFA] C++ : breakpoint in templates
- References: <20081216161416.GA33741@adacore.com>
- Reply-to: tromey at redhat dot com
>>>>> "Jerome" == Jerome Guitton <guitton@adacore.com> writes:
Joel mentioned yesterday that this patch had gone unreviewed.
For future reference, send a ping to the list a week or two after you
send a patch.
[...]
Jerome> In this case, expand_line_sal appends only one item, the best
Jerome> one in all symtab; I think that it should append all best
Jerome> matches (that is to say: all matches that are as good as the
Jerome> best one).
This makes sense to me.
Jerome> The patch in attachment should fix the problem. Testsuite run on
Jerome> x86-linux, no regression. New testcase will follow. OK to apply?
It looks good to me. Please check it in, thanks.
Tom