This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Improve the fetch/store of general-purpose and floating-point PowerPC registers
- From: Joel Brobecker <brobecker at adacore dot com>
- To: S?rgio Durigan J?nior <sergiodj at linux dot vnet dot ibm dot com>
- Cc: luisgpm at linux dot vnet dot ibm dot com, gdb-patches at sourceware dot org, Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Date: Tue, 28 Apr 2009 13:07:25 -0700
- Subject: Re: [PATCH] Improve the fetch/store of general-purpose and floating-point PowerPC registers
- References: <1223404355.7030.20.camel@miki> <1224184035.27672.64.camel@miki> <1231289020.2026.3.camel@miki> <200901070955.n079twBj014790@brahms.sibelius.xs4all.nl> <1231344540.2026.7.camel@miki> <1231436749.2026.19.camel@miki> <1231503988.12849.6.camel@gargoyle> <1232558849.6328.23.camel@miki>
Sergio,
> 2009-01-21 Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com>
>
> * ppc-linux-nat.c (have_ptrace_getsetregs): New variable.
> (have_ptrace_getsetfpregs): Likewise.
> fetch_all_gp_regs): New function.
> (fetch_gp_regs): New function.
> (fetch_all_fp_regs): Likewise.
> (fetch_fp_regs): New function.
> (fetch_ppc_registers): Using the new methods to fetch general-
> purpose and floating-pointer registers.
> (store_all_gp_regs): New function.
> (store_gp_regs): Likewise.
> (store_all_fp_regs): New function.
> (store_fp_regs): Likewise.
> (store_ppc_registers): Using the new methods to store general-
> purpose and floating-pointer registers.
Sorry for the delay in reviewing this. I don't know much about ptrace
except as a user, but this seems to make sense. The only request I have
is for you to write a small comment describing each new function you
introduce. The patch is OK with those changes.
PS: I assume you tested the change on 2 systems, one with the
functionality, and one without?
Thanks,
--
Joel