This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve the fetch/store of general-purpose and floating-point PowerPC registers


Sergio,

> 2009-01-21  Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com>
> 
> 	* ppc-linux-nat.c (have_ptrace_getsetregs): New variable.
> 	(have_ptrace_getsetfpregs): Likewise.
> 	fetch_all_gp_regs): New function.
> 	(fetch_gp_regs): New function.
> 	(fetch_all_fp_regs): Likewise.
> 	(fetch_fp_regs): New function.
> 	(fetch_ppc_registers): Using the new methods to fetch general-
> 	purpose and floating-pointer registers.
> 	(store_all_gp_regs): New function.
> 	(store_gp_regs): Likewise.
> 	(store_all_fp_regs): New function.
> 	(store_fp_regs): Likewise.
> 	(store_ppc_registers): Using the new methods to store general-
> 	purpose and floating-pointer registers.

Sorry for the delay in reviewing this. I don't know much about ptrace
except as a user, but this seems to make sense. The only request I have
is for you to write a small comment describing each new function you
introduce. The patch is OK with those changes.

PS: I assume you tested the change on 2 systems, one with the
functionality, and one without?

Thanks,
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]