This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Better display command-line macros + doc addon [Re: [patch] doc: Document macros defined from command-line]
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Tue, 28 Apr 2009 13:16:59 -0700
- Subject: Re: [patch] Better display command-line macros + doc addon [Re: [patch] doc: Document macros defined from command-line]
- References: <20090306204631.GA27092@host0.dyn.jankratochvil.net> <uk571n15x.fsf@gnu.org> <20090309001422.GA29150@host0.dyn.jankratochvil.net>
Jan,
Did we (ahem, I) drop the ball on you, on this patch? Sorry about that.
I don't think the change of output was particularly necessary, but I do
think it makes it easier to understand from the user's point of view:
No need to know what line 0 means in DWARF...
> gdb/
> 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * macrocmd.c (info_macro_command): Print -Dname=value if LINE is zero.
> gdb/testsuite/
> 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.base/macscp.exp: New `options' parameter `-DFROM_COMMANDLINE'.
> (info_macro): Remova `decimal' declaration. New variable `nonzero'.
> Replace all uses of `decimal' by `nonzero'.
> (info macro FROM_COMMANDLINE): New test.
GDB and testsuite parts look OK to me. Thanks for doing this.
> gdb/doc/
> 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.texinfo (Macros): Note command-line for `info macro'. Append
> a new part on command-line defined macros.
I can't remember whether Eli approved the doco change or not, though.
--
Joel