This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Bug symtab/8367] [RFA] performance improvement of lookup_partial_symtab
- From: Jerome Guitton <guitton at adacore dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sources dot redhat dot com, Francois Rigault <francois dot rigault at amadeus dot com>
- Date: Wed, 29 Apr 2009 10:53:50 +0200
- Subject: Re: [Bug symtab/8367] [RFA] performance improvement of lookup_partial_symtab
- References: <20090114174542.GM84382@adacore.com> <20090115094511.GB80710@adacore.com> <20090428195726.GA31821@adacore.com>
Joel Brobecker (brobecker@adacore.com):
> > > 2009-01-14 Jerome Guitton <guitton@adacore.com>
> > >
> > > * symtab.c (lookup_partial_symtab): When looking up an absolute path
> > > in the partial symtabs, compare the base names before checking the
> > > full names.
>
> We're only 3.5 months late reviewing this patch :-(... This looks OK
> to me. I verified that this cannot create behavior changes due to
> find_and_open_source returning a fullname with a different basename
> (for instance if the source file was actually a link to another source
> file): openp only canonicalizes the directory portion of the fullname.
>
> So I think this is reasonable. Please go ahead and commit.
There has been an alternative patch for the same problem, submitted here:
http://sourceware.org/ml/gdb-patches/2009-03/msg00309.html
François' patch should handle one more problem (files can be the same
even if basenames differs). So I prefer his approach. I think there's
still some paperwork to be done before we can merge his changes into
GDB (copyright assignment), but I guess that it will happen at some
point in the future. If not, I will modify my patch to take the link
problem into account.