This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Python pretty-printing [6/6]
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Mon, 18 May 2009 05:25:00 +0000 (UTC)
- Subject: Re: Python pretty-printing [6/6]
- References: <m37i22bwoq.fsf@fleche.redhat.com>
Tom Tromey <tromey <at> redhat.com> writes:
>
> This patch adds MI support for pretty-printing.
>
> An MI varobj can now have dynamic children, supplied by a Python
> pretty-printer. Pretty-printing for a varobj can be disabled via an
> MI request.
>
> This patch also adds a way for MI users to fetch only a subset of
> available children.
>
> Finally, it adds the "python" MI feature.
I must admit I did not examine all of the code very closely -- and it's
probably not gonna be productive to be picking code nits in such a huge patch.
I have a couple of higher-level comments:
1. From the *MI* docs it is not apparent why the 'visualizer' passed is called
with varobj to get the real visualizer. Docs probably should be more explicit.
2. I am unsure about the -var-set-child-range function -- why is this an
integral part of this patch? Was this tried with any frontend, and found
sufficient/good? I don't think we ever reached a conclusion as to how to deal
with big number of children.
- Volodya