This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Prec/RFA] fix build error of prec in cygwin
On Thu, May 21, 2009 at 10:38:58AM +0800, Hui Zhu wrote:
>Ping
You are aware that it took you about seven days to respond to one of my
messages right?
I was confused by the fact that you didn't seem to be using CVS to
generate your diffs and, on closer inspection, I see that there are
multiple places where coercion is used inappropriately when the format
specifier should just have matched the parameter.
Some of your changes are now using "%u" with "(int) sizeof" (which is
wrong) and some of the existing code is just using "(int) sizeof" with
"%d" which is also wrong.
So, in other words, the file was already not quite "right" and I don't
think your changes are getting it much closer to "right".
I was not implying that your changes didn't fix compiler errors. I was
saying that I didn't think they were the correct way to fix the errors.
However, since I am apparently the only person who cares about this
stuff, and it doesn't seem like my point is getting across, I think I'll
just shut up now. Other, global maintainers have said that they were ok
with your changes so I'm not going to object even if they don't make
sense to me.
cgf