This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] i386/amd64 h/w watchpoints in gdbserver
- From: Doug Evans <dje at google dot com>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: Pedro Alves <pedro at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Tue, 2 Jun 2009 17:18:13 -0700
- Subject: Re: [RFA] i386/amd64 h/w watchpoints in gdbserver
- References: <20090430071853.99F5584890@localhost> <e394668d0905181611h13db1d0dr93be7507c6078687@mail.gmail.com> <e394668d0905181627ref57f83oc11507d07c0382a7@mail.gmail.com> <001201c9d860$e66c5850$b34508f0$@u-strasbg.fr> <e394668d0906020836o1d4292e6s36eaae6e5d262bda@mail.gmail.com> <000301c9e3d4$218eac20$64ac0460$@u-strasbg.fr>
On Tue, Jun 2, 2009 at 3:47 PM, Pierre Muller <muller@ics.u-strasbg.fr> wrote:
>> > Do we have an automated testsuite result comparison script that can
>> be
>> > used for gdbserver testing?
>>
>> I just use --target_board=native-gdbserver.exp and compare
>> before/after.
>> ref: http://sourceware.org/gdb/wiki/Native_gdbserver_testing
>>
>> No regressions on amd64 gdbserver, 32-bit and 64-bit.
>
> ?Did you try to remove the line saying that
> gdbserver does not support hardware watchpoints,
> does it change anything?
The version I used has:
# Can't do hardware watchpoints, in general.
# But can for i386.
if { [istarget i?86-*-*] || [istarget x86_64-*-* ] } {
;# leave unset, testcases check for whether it is defined
} else {
set_board_info gdb,no_hardware_watchpoints 1
}
Plus while running the testsuite I had this applied:
--- i386-low.c= 2009-06-02 17:11:37.000000000 -0700
+++ i386-low.c 2009-06-02 17:11:52.000000000 -0700
@@ -142,7 +142,7 @@
#define ALL_DEBUG_REGISTERS(i) for (i = 0; i < DR_NADDR; i++)
/* Whether or not to print the mirrored debug registers. */
-static int maint_show_dr = 0;
+static int maint_show_dr = 1;
/* Types of operations supported by i386_handle_nonaligned_watchpoint. */
typedef enum { WP_INSERT, WP_REMOVE, WP_COUNT } i386_wp_op_t;
>
>> > ?I can test compilation on cygwin,
>> > but testing can only be done manually...
>>
>> Thanks, can you give this a try?
>
> ?I was able to compile without problems
> and test gdb.base/watchpoint.exp
>
> and got 60 PASS (same as gdb itself).
Thanks for running the tests.
How about watchthreads.exp, watchthreads2.exp?