RE: [RFA] Fix bug in add_alias_cmd

["Pierre Muller" <muller at ics dot u-strasbg dot fr>]

> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé?: Monday, June 08, 2009 5:37 PM
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFA] Fix bug in add_alias_cmd
> 
> >>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:
> 
> Pierre>   This is due to "bu" being an alias command of "ubreak"
> Pierre> for xdb options, but "ubreak" doesn't seem to exist anywhere
> Pierre> and I found no trace of it anywhere is the sources :(
> 
> Pierre> I fact after looking at the sources, it appears to me
> Pierre> that the assertion itself is wrong.
> Pierre> prehookee should also be NULL, as the other pointers tested.
> 
> Pierre> This small patch fixes it.
> 
> Pierre> OK to commit?
> 
> Yes, thanks.
> IMO, you could have put this patch in under the "obvious" rule.

  Thanks, I committed the patch.
 
> Pierre> PS: What should we do about
> Pierre> Could I also remove that line
> Pierre>  if (xdb_commands)
> Pierre>     {
> Pierre>       add_com_alias ("ba", "break", class_breakpoint, 1);
> Pierre>       add_com_alias ("bu", "ubreak", class_breakpoint, 1);
> Pierre>     }
> 
> You can just delete the "bu" line.
Patch also committed.
 
> If you want you could do some archaeology to see whether ubreak ever
> existed and, if so, when and why it was removed.

  I already did a 
grep -R -n -i ubreak * 
at src/gdb level, it returned only that
single line, where else could I find something?
Google on 'gdb ubreak' didn't find anything interesting either.


Pierre