This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] testsuite/gdb.base/fullname.exp fix
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: "Pierre Muller" <muller at ics dot u-strasbg dot fr>
- Date: Sun, 21 Jun 2009 02:27:47 +0100
- Subject: Re: [RFA] testsuite/gdb.base/fullname.exp fix
- References: <000501c9f12b$68c860e0$3a5922a0$@u-strasbg.fr>
On Friday 19 June 2009 23:15:08, Pierre Muller wrote:
>
> fullname.exp currently fails compilation
> of windows targets because it tries to recompile
> the executable, while it is still running under GDB.
Might this be a new failure? We have a few bfd_cache_close_all
calls around to prevent this. Hmm, probably not. Anyone
thinks we should do something to prevent this from happening?
AFAICS, this particular case is something like:
> gdb filefoo
(gdb opens the exec_file does things, and the calls bfd_cache_close_all.)
(gdb) b main << this reads file memory and reopens the bfd, nothing closes it.
Maybe we could always call bfd_cache_close_all after executing a
command... Dunno, maybe that's going too far? Probably will still be
defeated by the new dwarf memory mapped files support if that ever
is ported to Windows (I think Cygwin has now some magic to be able
to remove open files? Maybe I'm dreaming.)
On Friday 19 June 2009 23:15:08, Pierre Muller wrote:
> 2009-06-19 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * fullname.exp: Exit gdb before recompile as some operating systems
> lock the executable while it is running.
>
This is OK if it isn't a new failure, and no one has replies to the
above questions, and if you move the "why" note from the changelong entry
to the .exp file.
The changelog header indicates "who" and "when". The changelog entry
itself indicates "what". The "why" belongs in the code.
--
Pedro Alves