This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] Use LONGEST instead of value for index arithmetic


On Fri, Jun 26, 2009 at 05:49:07PM +0200, Ulrich Weigand wrote:
> Hello,
> 
> this patch implements the change I mentioned recently: use LONGEST instead
> of struct value to represent array indexes (and similarly the integer
> operands to pointer arithmetic).  This has the advantage that index
> computations can be performed in host instead of target arithmetic,
> and not just eliminates a bunch of references to global built-in types,
> but makes both implementation and users of the value_subscript and
> pointer arithmetic routines quite a bit simpler.

Looks good to me.  I noticed you're removing several error calls; do
those garbage cases still produce some error message?  I guess they
must be untested :-(

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]