This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Patch to fix reverse return from subroutine error
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Michael Snyder <msnyder at vmware dot com>, Hui Zhu <teawater at gmail dot com>, Marc Khouzam <marc dot khouzam at ericsson dot com>
- Date: Sat, 27 Jun 2009 20:49:35 +0100
- Subject: Re: [RFA] Patch to fix reverse return from subroutine error
- References: <daef60380906110127p5a834832k557f01e12d7a40e2@mail.gmail.com> <4A466BAE.2010305@vmware.com>
> - || execution_direction == EXEC_REVERSE))
> + || (execution_direction == EXEC_REVERSE
> + && ecs->event_thread->step_frame_id.stack_addr_p
> + && get_frame_id (get_current_frame ()).stack_addr_p
> + && !gdbarch_inner_than (current_gdbarch,
> + ecs->event_thread->step_frame_id.stack_addr,
> + get_frame_id
Sorry to pitch in so late, but this doesn't look right to me.
Common code shouldn't be accessing frame id members directly, frame ids
are supposed to be opaque. What is this trying to do?
--
Pedro Alves