This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] testsuite: Fix racy gdb.mi/mi-nsthrexec.exp FAIL


On Tue, 30 Jun 2009 21:37:50 +0200, Pedro Alves wrote:
> On Tuesday 30 June 2009 19:23:34, Jan Kratochvil wrote:
> 
> > @@ -59880,10 +59843,9 @@ Expecting: ^(-thread-info[
> >  ]+[(]gdb[)] 
> >  [ ]*)
> >  -thread-info
> > -~"Current language:  auto; currently asm\n"
[...]
> This must be from the language_info call in inf-loop.c, that
> is always called when something stops.  In light of non-stop mode,
> this is a weird place to output this (and to change expected
> language) --- the thread that just stopped may not be the
> current thread.

Understood, admitting I did not found this point out.


> Other testsuite code may be using racy .*'s simply because
> it is not being exercised in non-stop mode (we had to remove a bunch of
> those before, tightening the expected strings up),

OK, thanks for the notice to be aware of it.


> ... Ok.

Checked-in:
	http://sourceware.org/ml/gdb-cvs/2009-06/msg00204.html



Thanks for the review,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]