Re: Reporting the OSABI in target descriptions.

[Eli Zaretskii <eliz at gnu dot org>]

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Mon, 6 Jul 2009 16:17:58 +0100
> Cc: Eli Zaretskii <eliz@gnu.org>
> 
> > So that gdbserver supports this, I've tweaked the regformats/regdat.sh
> > script to grok a new "osabi" field in the .dat files, and done
> > a couple of examples: x86/x86_64-linux, which covers the specifying
> > the osabi in the .dat files directly, and mips-linux, that covers doing
> > it in from an embedded xml file.  I didn't touch other archs as their
> > xml and dat files didn't have "linux" in the filename, but
> > it probably just means that we'd have to go add such linux files,
> > or check which ones aren't named foolinux.xml or foolinux.dat,
> > but are only really used by gdbserver-linux.

Sorry, I don't follow: why just Linux?

> >  We can of course
> > easilly add .xml and .dat files for Windows or other hosts
> > gdbserver runs on.

Perhaps we should indeed add that for the popular platforms.

> Eli, are is the docs (mostly doing the same as the description of
> the "architecture" element does) and NEWS patch hunks below okay?

Yes, with a couple of comments:

> +* Target descriptions can now describe the target OS ABI.  See the
> +section on target descriptions in the user manual for more
> +information.

In fact <osabi> is described in "Target Description Format", not in
"Target Descriptions".  So maybe use the exact section name here.

> +@cindex <osabi>

"<osabi>" is a kind of symbol, so it's better to have it in @code.

> +An @samp{<osabi>} element has this form:
> +
> +@smallexample
> +  <osabi>@var{osabi}</osabi>
> +@end smallexample
> +
> +@var{osabi} is an OS ABI name from the same selection accepted by

Using "osabi" both for the tag and the OS ABI name could confuse the
reader.  Suggest to use "abi" or "abi-name" for the latter.

Thanks.