This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA Darwin]: Add push_dummy_call for i386



On Jul 6, 2009, at 12:16 PM, Mark Kettenis wrote:
I quoted LowLevelABI.pdf.  What is wrong in this sentence ?  (Keep
in mind that I am not a native english speaker!)

Heh well, if it is a quotation, better not change it. But perhaps the comment should indicate this is a quotation from the ABI document?

I propose this:


/* According to Mac OS X ABI document (passing arguments):
6. The caller places 64-bit vectors (__m64) on the parameter area,
aligned to 8-byte boundaries.
7. [...] The caller aligns 128-bit vectors in the parameter area to
16-byte boundaries. */



Is it OK with that change (or do you prefer to review the whole patch again) ?


Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]