This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Add a new modifier /c to "disassemble" command to make it output binary code
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 09 Jul 2009 22:29:41 +0300
- Subject: Re: Add a new modifier /c to "disassemble" command to make it output binary code
- References: <daef60380907082335j78b9ae35jaf552124a65022a3@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Thu, 9 Jul 2009 14:35:54 +0800
> From: Hui Zhu <teawater@gmail.com>
>
> +With a /c modifier, binary code are included.\n\
I think you mean "hex dump of machine code", not "binary code". In
any case, "binary code is included", in singular, not plural.
> -@itemx disassemble /m
> +@itemx disassemble /mc
Isn't it better to show that the modifiers are independent? Like
this:
@item disassemble
@itemx disassemble /m
@itemx disassemble /c
> -the @code{/m} modifier.
> +the @code{/m} modifier and print binary code by specifying
> +the @code{/c}.
Again, I think "machine code in hex dump format" is better.
Okay with these changes.