This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA Darwin v2]: Add push_dummy_call for i386
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 16 Jul 2009 12:07:15 -0700
- Subject: Re: [RFA Darwin v2]: Add push_dummy_call for i386
- References: <20090706073517.GA77238@Macintosh-2.local>
> 2009-07-06 Tristan Gingold <gingold@adacore.com>
>
> * i386-darwin-tdep.c (i386_m128_p): New function.
> (i386_darwin_arg_type_alignment): Ditto.
> (i386_darwin_push_dummy_call): Ditto.
> (i386_darwin_init_abi): Define Darwin specific push_dummy_call.
> Adjust long_double size. Adjust pc offset in setjump buffer.
This looks OK to me.
> +static int
> +i386_m128_p (struct type *type)
> +{
> + return TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR (type)
> + && TYPE_LENGTH (type) == 16;
> +}
Just one tiny comment: The GNU Coding Standard likes it when we use
parens around the returned expression in this case, even if it is
unecessary. It helps automatic formatting. Would you mind rewriting
it as follow:
return (TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR
&& TYPE_LENGTH (type) == 16);
?
--
Joel