This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] [2/9] Cell multi-arch: Implement tdesc <compatible> feature for Cell
On Fri, Jul 31, 2009 at 05:51:02PM +0200, Ulrich Weigand wrote:
> Dan,
>
> when checking in the Cell/B.E. patches I ran into a small conflict with
> a change you committed as part of ARM VFP / NEON support. Basically,
> I need to use a different set of expedited registers with Cell/B.E.
> than with other PowerPC sub-platforms, and your patch to the features
> Makefile removed the capability for specifying that:
>
> - echo "expedite:$($*-expedite)" >> $(outdir)/$*.tmp
> + echo "expedite:$($(firstword $(subst -, ,$(notdir $*)))-expedite)" >> $(outdir)/$*.tmp
>
> To resolve this conflict, I've now added back that capability, but
> optionally: if there is an -expedite variable corresponding to the
> full platform string, use that; otherwise fall back to the -expedite
> variable for the core architecture.
>
> Does this look OK to you? If you prefer a different solution, please
> let me know, I'll be happy to fix it ...
This looks fine, thanks! All I wanted to do was reduce the
repitition; I regularly used to get conflicts on this chunk of
Makefile, and adding a new register set shouldn't really require
touching it.
--
Daniel Jacobowitz
CodeSourcery