This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/RFC] Add dump and load command to process record and replay
- From: Michael Snyder <msnyder at vmware dot com>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>, Eli Zaretskii <eliz at gnu dot org>
- Date: Sat, 01 Aug 2009 12:20:18 -0700
- Subject: Re: [RFA/RFC] Add dump and load command to process record and replay
- References: <daef60380908010030o1189baaal3927a286e069971c@mail.gmail.com>
Hui Zhu wrote:
Hi,
This patch add command record dump and record load to make prec can
dump execution log to a file and load it later. And load can work
with core file.
And I include "mem_entry_not_accessible"(not_replay) patch to this
patch because when replay with core file, some address in lib cannot
be read and write.
Augh! No -- please, this is lumping too much together.
Smaller, more discrete patches are much easier to review.
1) You already have a patch thread for the memory-not-accessible
change -- let's finish that idea there, not lump it in here.
2) I think the idea of saving and restoring the recording
to a file is GREAT -- but can you please give us a patch
that adds that, by itself.
3) I don't really understand how core files fit into this,
but I'd love to discuss that idea in a separate patch thread.
It really adds a lot of complexity to this patch, which it seems
to me could be much simpler and easier to review if it added
only one thing at a time.