This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] -Wall patches


Michael Snyder wrote:
Aleksandar Ristovski wrote:
Hello,


I have internally made changes necessary to get clean compile with -Wall compiler option. I tried to break down the patch to related files; I am intentionally not writing a changelog since most of the changes are mechanical and consist of removing unused variables, several unused functions, gdb_byte/char casting.


I would not mind if respective maintainers looked at the patches for their files and committed the changes (otherwise it will be quite cumbersome and somewhat overwhelming for me to keep the patch applicable; not to mention change log and all).

Your change subsumes the change that I submitted to remove unused variables from remote.c -- I'll hold off committing that change 'till we decide what to do about it.

Michael


I would suggest that you commit your changes, and just let me know here that a patch from my list is not relevant any more. E.g. "Wall-remote.diff not applicable any more". There is also Wall-tracepoint.diff which is in your domain too.


I am not eager to commit all that myself, nor to seek credit, it is only trivial cleanup, but I would like to see gdb compile with -Wall and no warnings.


Thanks,


--
Aleksandar Ristovski
QNX Software Systems


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]