This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] symfile find_separate_debug_file
- From: Doug Evans <dje at google dot com>
- To: tromey at redhat dot com
- Cc: Aleksandar Ristovski <aristovski at qnx dot com>, gdb-patches at sources dot redhat dot com
- Date: Thu, 13 Aug 2009 15:44:47 -0700
- Subject: Re: [patch] symfile find_separate_debug_file
- References: <h5pnol$ejf$1@ger.gmane.org> <m3prazl7io.fsf@fleche.redhat.com>
On Thu, Aug 13, 2009 at 2:37 PM, Tom Tromey<tromey@redhat.com> wrote:
>>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:
>
> Aleksandar> * symfile.c (find_separate_debug_file): Fix the case when
> Aleksandar> objfile has only basename as its name.
>
> Aleksandar> + ? ? somewhere, unless there isn't. ?See allocate_objfile. ?*/
>
> Funny comment :)
Ya, reminds me of one in c++:
3.5 Program and Linkage [basic.link] paragraph 6:
"extern means static except when it doesn't"
> This is ok.
>
> It seems to me that we probably need some kind of OBJF_IS_FILE flag,
> because we do have objfiles that don't come from files, but that still
> have names. ?Constructing file names derived from these names seems
> bogus.
fwiw, I wouldn't mind an elaboration of the comment, e.g. provide an
example when "unless there isn't" happens. Otherwise I have to go
looking and assume what I find is what the comment is referring to.