This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] -Wall patches

Pedro Alves wrote:
I was quickly skimming through the patch, and I saw this:

On Thursday 06 August 2009 21:17:25, Aleksandar Ristovski wrote:
--- src0/gdb/valops.c 2009-07-31 14:43:27.000000000 -0400
+++ src1/gdb/valops.c 2009-08-06 09:04:20.000000000 -0400
@@ -270,7 +270,6 @@ value_cast_structs (struct type *type, s
struct value *
value_cast_pointers (struct type *type, struct value *arg2)
{
- struct type *type1 = check_typedef (type);
struct type *type2 = check_typedef (value_type (arg2));
struct type *t1 = check_typedef (TYPE_TARGET_TYPE (type));
struct type *t2 = check_typedef (TYPE_TARGET_TYPE (type2));
@@ -866,6 +865,9 @@ value_assign (struct value *toval, struc
value_reg = VALUE_REGNUM (toval);
if (!frame)
+ frame = get_current_frame ();
+
+ if (!frame)
error (_("Value being assigned to is no longer active."));

Looks like it was accidentally included.  It looks like the
workaround for "set reg=foo", when there's no valid frame id.


Yes, it was included by accident. And I think the workaround din't work for me (for whatever reason)... but that's another story.

--
Aleksandar Ristovski
QNX Software Systems

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]