This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Token cleanup in c-exp.y

From: Tom Tromey <tromey at redhat dot com>
To: Keith Seitz <keiths at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 25 Aug 2009 12:07:33 -0600
Subject: Re: [RFA] Token cleanup in c-exp.y
References: <4A9313C2.3050907@redhat.com> <m3skffvqvl.fsf@fleche.redhat.com> <4A94248B.20701@redhat.com>
Reply-to: Tom Tromey <tromey at redhat dot com>

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Tom> The last field should be 1 here, and then the tokentab2 and tokentab3
Tom> logic in yylex needs the same cxx_only treatment as ident_tokens.

Keith> Yes, indeed. I've fixed that

Thanks.

Tom> I suppose that the "::" operator also needs to be C++-only.

Keith> I don't think we can do that. "::" is also used by gdb for
Keith> non-language constructs like filename::function and
Keith> function::variable. There are several scattered tests on this already.

Thanks for looking into this and adding the comment.

Keith> New patch attached.

This is ok.

Tom

Follow-Ups:
- Re: [RFA] Token cleanup in c-exp.y
  - From: Keith Seitz

References:
- [RFA] Token cleanup in c-exp.y
  - From: Keith Seitz
- Re: [RFA] Token cleanup in c-exp.y
  - From: Tom Tromey
- Re: [RFA] Token cleanup in c-exp.y
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]