This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Speed up find_pc_section


On Sun, Aug 23, 2009 at 3:48 PM, Paul Pluzhnikov<ppluzhnikov@google.com> wrote:
> On Fri, Aug 21, 2009 at 4:30 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
...
>> I'm still not completely happy about the assertions you added. ?An
>> assertion failure is supposed to be an indication of a bug in GDB
>> -- it should never be possible to trigger the assertion just by
>> providing particular user input (this includes the binary file).
>
> I am still working on fixing that part...

Here is the patch. Tested on Linux/x86_64 and on Fedora11/i686 with
prelinking. No regressions.
It also passes Jan's new gdb.base/solib-overlap.exp test case for RH
Bug 515434, issuing these warnings:

warning: Unexpected overlap between section `.note.gnu.build-id' from
`/home/paul/gdb-cvs/build/gdb/testsuite/gdb.base/solib-overlap-lib1-0x50000000.so'
[0xf4, 0x118) and section `.note.gnu.build-id' from
`/home/paul/gdb-cvs/build/gdb/testsuite/gdb.base/solib-overlap-lib2-0x50000000.so'
[0xf4, 0x118)
warning: Unexpected overlap between section `.gnu.hash' from
`/home/paul/gdb-cvs/build/gdb/testsuite/gdb.base/solib-overlap-lib1-0x50000000.so'
[0x118, 0x158) and section `.gnu.hash' from
`/home/paul/gdb-cvs/build/gdb/testsuite/gdb.base/solib-overlap-lib2-0x50000000.so'
[0x118, 0x158)
... etc ... etc ...

Thanks,
-- 
Paul Pluzhnikov

2009-08-25  Paul Pluzhnikov  <ppluzhnikov@google.com>

        * objfiles.c (qsort_cmp): Remove asserts.
        (insert_section_p, filter_debuginfo_sections): New function.
        (filter_overlapping_sections): Likewise.
        (update_section_map): Adjust.

Attachment: gdb-find_pc_section-20090825.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]