This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c


Mark Kettenis <mark.kettenis@xs4all.nl> writes:

>> From: Hui Zhu <teawater@gmail.com>
>> Date: Sun, 30 Aug 2009 21:15:22 +0800
>> 
>> Index: gdb/i386-linux-tdep.c
>> ===================================================================
>> --- gdb.orig/i386-linux-tdep.c	2009-08-23 21:17:37.000000000 +0800
>> +++ gdb/i386-linux-tdep.c	2009-08-30 20:19:53.828125000 +0800
>> @@ -374,7 +374,7 @@
>>    if (tmpu32 > 499)

Also, magic numbers like this are bad as well.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]