This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: Hui Zhu <teawater at gmail dot com>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, freephp at gmail dot com
- Date: Sat, 5 Sep 2009 14:15:41 -0700
- Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c
- References: <daef60380908300615u40f59a38t7d2c2f2252c5924d@mail.gmail.com> <200908301356.n7UDuO4a006136@brahms.sibelius.xs4all.nl> <daef60380908300709i382261c9w6152a694dcdb5975@mail.gmail.com> <daef60380908300737k239bf7dcp6b4eb99c3b23b6f6@mail.gmail.com> <daef60380908310122w5ff65266wdb1a6667bdc8407f@mail.gmail.com> <4AA2CAFA.809@vmware.com>
> I could suggest casting it to (unsigned int), but it wouldn't
> really make any difference, would it? Mark -- Jiang -- would
> that make you guys more comfortable?
Short term, I'd rather see us read the syscall number as a signed
number since this is what record_linux_system_call expects. We can
decide whether to rationalize as a signed or unsigned as a separate
patch. I think Mark was OK with the patch I sent yesterday, except
that he said we should add a check against negative values.
There is also a cast that is unnecessary in the error message.
Hui can use %s/paddress rather than %d/cast.
--
Joel