This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Speed up find_pc_section

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Ulrich Weigand <uweigand at de dot ibm dot com>, Ulrich Weigand <Ulrich dot Weigand at de dot ibm dot com>, gdb-patches ml <gdb-patches at sourceware dot org>, Tom Tromey <tromey at redhat dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>
Date: Thu, 10 Sep 2009 18:29:46 -0700
Subject: Re: [patch] Speed up find_pc_section
References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <200908211130.n7LBUCJc011108@d12av02.megacenter.de.ibm.com> <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> <20090909055824.GB11738@adacore.com> <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> <20090910182952.GK20694@adacore.com>

On Thu, Sep 10, 2009 at 11:29 AM, Joel Brobecker <brobecker@adacore.com> wrote:

>> I am not sure calling complaint rather than warning is really the right
>> thing here: complaints are silent unless the user explicitly turns them on,
>> and overlapping sections indicate a real problem of some sort.
>
> I still think we should use a complaint in this case.

Adjusted patch attached.

Thanks,
-- 
Paul Pluzhnikov

2009-09-10  Paul Pluzhnikov  <ppluzhnikov@google.com>

      * objfiles.c (qsort_cmp): Remove asserts.
      (insert_section_p, filter_debuginfo_sections): New function.
      (filter_overlapping_sections): Likewise.
      (update_section_map): Adjust.

Attachment: gdb-find_pc_section-20090910-2.txt
Description: Text document

Follow-Ups:
- RE: [patch] Speed up find_pc_section
  - From: Pierre Muller

References:
- Re: [patch] Speed up find_pc_section
  - From: Joel Brobecker
- Re: [patch] Speed up find_pc_section
  - From: Paul Pluzhnikov
- Re: [patch] Speed up find_pc_section
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]