This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Speed up find_pc_section


On Fri, Sep 11, 2009 at 12:39 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:

>> - ?return 0;
>> + ?if (sect1->objfile->mtime < sect2->objfile->mtime) return -1;
>> + ?if (sect1->objfile->mtime > sect2->objfile->mtime) return 1;
>> + ?return 0;
>> }
>
> This snippet caught my eye. ?Please put those return statements on a
> line of their own.

This wasn't a real patch, just something I typed by hand.
Yes, I will certainly put return on a separate line IF it is
considered reasonable (which I somewhat doubt).


-- 
Paul Pluzhnikov


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]