This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Another proposal for frontends and queries.


On Friday 18 September 2009 05:59:25, Hui Zhu wrote:
> + ? ? ? ? ?if (record_memory_change_default)
> + ? ? ? ? ? ?n = yquery (_("Because GDB is in replay mode, writing to memory "
> ???????????????? ? ? ? ? "will make the execution log unusable from this "
> ???????????????? ? ? ? ? "point onward. ?Write memory at address %s?"),
> -??????????????? ? ? ? paddress (target_gdbarch, offset)))
> +??????????????? ? ? ? paddress (target_gdbarch, offset));
> +??????? ?else
> + ? ? ? ? ? ?n = nquery (_("Because GDB is in replay mode, writing to memory "
> +??????????????? ? ? ? ? "will make the execution log unusable from this "
> +??????????????? ? ? ? ? "point onward. ?Write memory at address %s?"),
> +??????????????? ? ? ? paddress (target_gdbarch, offset));
> +??????? ?if (!n)

Having just "<enter>" behave differently depending on a setting, is
bad UI/usability, IMO.  If you switch to 'query', you force the user to
type 'y' or 'n' explicitly, which is a Good Thing.

-- 
Pedro Alves

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]