This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Check solib bfd arch


On Friday 18 September 2009 17:25:11, Daniel Jacobowitz wrote:

> A description can cover many areas, but is not required to cover any
> of them.  I don't think anything should rely on "is there a
> description".

Good point, although we could check if the description
included an arch.

> It does seem to me like the test should be symmetric here:
>   a = bfd_get_arch_info (abfd);
>   if (b->compatible (b, a) != b
>       && a->compatible (a, b) != a)

I think that's the same in practice as Joel's original
patch then, since `compatible' either returns either
NULL, a or b.  This still catches the
obviously-incompatible cases, so may be worth keeping,
while anything smarter is probably not worth the effort
then.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]