This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Check solib bfd arch

On Fri, Sep 18, 2009 at 05:41:43PM +0100, Pedro Alves wrote:
> > It does seem to me like the test should be symmetric here:
> >   a = bfd_get_arch_info (abfd);
> >   if (b->compatible (b, a) != b
> >       && a->compatible (a, b) != a)
> 
> I think that's the same in practice as Joel's original
> patch then, since `compatible' either returns either
> NULL, a or b.  This still catches the
> obviously-incompatible cases, so may be worth keeping,
> while anything smarter is probably not worth the effort
> then.

You're right, this is the same in practice.  I don't have a strong
preference as to which form we use; whichever folks find clearer.

-- 
Daniel Jacobowitz
CodeSourcery
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]