This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Record segfault


Michael,

> This seems fine to me.  Please check it into the main branch,
> but don't add it to the release branch unless Joel says it's OK.

It seems like a worthwhile patch to have, since it fixes a SEGV
(right?). Are you confident about the patch? It seems relatively
straightforward. My only comment is that it eliminates a query
when the user types a record stop - is that desirable? I guess
it is: What are the chances of someone typing "record stop" and
not wanting to stop the recording session?

In other words: I am ok with the patch being applied to the branch.
If you are, can you give Hui the go-ahead?

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]