Re: [ia64] Regression: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Tue, 29 Sep 2009 18:07:24 +0200, Ulrich Weigand wrote:
> I agree that ia64_convert_from_func_ptr_addr should not error out in such cases,
> so your patch looks good to me (would have looked good in any case, even without
> the Obj-C changes) ...   Are you going to check it in?

Considering this as your check-in approval so yes.

I also think this patch is appropriate no matter if it will be required for
the descriptor solution.


> > On ia64-rhel5.4-linux-gnu with this patch there are still these regressions:
> > +FAIL: gdb.base/corefile.exp: print func2::coremaker_local
> > +FAIL: gdb.base/corefile.exp: backtrace in corefile.exp
> > +FAIL: gdb.base/corefile.exp: up in corefile.exp
> > +FAIL: gdb.base/corefile.exp: up in corefile.exp (reinit)
> > +FAIL: gdb.base/gcore.exp: where in corefile (pattern 1)
> > +FAIL: gdb.base/gcore.exp: corefile restored general registers
> > +FAIL: gdb.base/gcore.exp: corefile restored all registers
> > +FAIL: gdb.base/gcore.exp: capture_command_output failed on print array_func::local_array.
> > +FAIL: gdb.base/gcore.exp: corefile restored stack array
> > +FAIL: gdb.base/gcore.exp: corefile restored backtrace
> > +FAIL: gdb.gdb/selftest.exp: unknown source line after step over ttyarg initialization
> > +FAIL: gdb.gdb/selftest.exp: step into xmalloc call
> > +FAIL: gdb.threads/gcore-thread.exp: corefile contains at least two threads
> > +FAIL: gdb.threads/gcore-thread.exp: a corefile thread is executing thread2
> > +FAIL: gdb.threads/gcore-thread.exp: thread2 is current thread in corefile
> 
> Are these regressions also introduced by my Obj-C patch?  That seems
> really odd to me ...

Tested HEAD with our change unpatched -> HEAD with my ia64 change.

Verified gdb.base/corefile.exp is reproducible this way.

Therefore going to check these specific cases more.


Thanks,
Jan