This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Set calling convention of methods
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jonas Maebe <jonas dot maebe at elis dot ugent dot be>
- Cc: tromey at redhat dot com, Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sourceware dot org
- Date: Wed, 30 Sep 2009 10:36:22 -0700
- Subject: Re: [patch] Set calling convention of methods
- References: <7B6EF4DA-76C8-4D9C-8B9F-94153EF1C4E1@elis.ugent.be> <m3zleb2ne3.fsf@fleche.redhat.com> <691B0BA8-C606-42FF-A796-76CC9C31556A@elis.ugent.be> <200904222215.n3MMF0p2006994@brahms.sibelius.xs4all.nl> <19C107AA-5271-4C23-A6D2-AFF75BBAC4E4@elis.ugent.be> <m3bpp3oode.fsf@fleche.redhat.com> <5AA3BCA9-1ECF-446E-8B49-3132F0E470FB@elis.ugent.be> <20090930000225.GA10338@adacore.com> <8F3B6095-4766-432D-ABB5-AB4DAA2D5572@elis.ugent.be> <20090930161001.GD10338@adacore.com>
Jonas,
> >> As far as I am concerned, I can't see a problem with using DWARF
> >> declarations even from stabs.
> >
> > We could include the dwarf2.h header in the stabs reader and set the
> > calling convention to DW_CC_normal in all cases.
>
> That, or explicitly document that calling smash_to_method_type
> with a calling_convention=0 means a normal calling convention.
> We'd then just add an extra check at the beginning of this function
> that translates calling_convention from zero to DW_CC_normal.
> My money is on including dwarf2.h from stabsread.c. We do this
> from other places, so why not from stabsread.c?
When you're ready, can you resubmit an updated version of your patch
that adds calling-convention support for methods? Tom and I discussed
the issue on IRC, and we think it's fine to include dwarf2.h from
stabsread.c.
--
Joel