This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix breakpoints when several source files have the same name


Hi Joel,

Joel Brobecker a écrit :
Really really sorry for taking so long before reviewing this patch.
Please don't hesitate to send pings on the list to remind us of a patch
that is sitting unreviewed for more than a week or two.

Ok, I haven't been very pushy on this patch neither but I'm really glad to make some progress on it as it is still a problem with no real work around.


How about changing the patch to only do the fullname matching iff
(if and only iff) the simple filename matches first.  In other words,
compute the symtab/psymtab fullname only if the filename matches.

That's fine for me but months ago I get an email offlist from Jan Kratochvil who has fixed this bug with another patch.


I think his patch is better than mine. Instead of adding another particular case, he has rewritten some functions and add a test case. The drawback is that it is more difficult to be sure that there is no regression and I have understood that Jan wants to work a bit more or it.

Anyway, I would really like to get this bug fixed, so if you think it's ok, I can update my own patch.

Regards,

Sébastien


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]